Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize bits and pieces of storage display #17436

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Modernize bits and pieces of storage display #17436

merged 5 commits into from
Feb 14, 2024

Conversation

jmchilton
Copy link
Member

Typescript, fetchers, and better use of Pydantic/FastAPI.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton added kind/refactoring cleanup or refactoring of existing code, no functional changes area/objectstore labels Feb 7, 2024
@jmchilton jmchilton force-pushed the modernize_storage branch 2 times, most recently from 5dcb1cb to 822eda9 Compare February 8, 2024 14:37
davelopez
davelopez approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid improvements! Still WIP?

client/src/components/Dataset/DatasetStorage/DatasetStorage.test.js Outdated Show resolved Hide resolved
@jmchilton jmchilton marked this pull request as ready for review February 13, 2024 14:46
@github-actions github-actions bot added this to the 24.0 milestone Feb 13, 2024
@martenson martenson merged commit 8c52b92 into galaxyproject:dev Feb 14, 2024
55 checks passed
@martenson
Copy link
Member

thanks John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

@martenson martenson martenson approved these changes

Assignees
No one assigned
Labels
area/objectstore kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jmchilton @martenson @davelopez